[
https://issues.apache.org/jira/browse/IGNITE-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737447#comment-14737447
]
Andrey Gura commented on IGNITE-1016:
-------------------------------------
Alexey, Valentin,
I found that PR doesn't contain all my changes. Probably I made mistake during
migartion to Github.
Patch applied again. {{IgniteCacheTestSuite}} and {{IgniteCacheTestSuite2}} are
looks good. But I think that all test should be executed because master has a
lot of new changes. So new PR created - https://github.com/apache/ignite/pull/80
Aslo I want discuss default value of {{excludeNeighbors}} again. I found that
{{GridCacheProcessor.validate}} method throws exception in case of replicated
cache and {{RendezvousAffinityFunction}} with {{excludeNeighbors == true}}.
From my point of view we should remain default value of {{excludeNeighbors ==
false}}. Otherwise user should explicitly define {{RendezvousAffinityFunction}}
in configuration for replicated cache.
The second issue is related with warning about ignoring {{excludeNeighbors}}
flag in case when topology has no enough nodes to assign backups. I think that
this warning is redundant because it will printed out always during starting
cluster.
Thoughts?
> Add excludeNeighbors and backupFilter to FairAffinityFunction
> -------------------------------------------------------------
>
> Key: IGNITE-1016
> URL: https://issues.apache.org/jira/browse/IGNITE-1016
> Project: Ignite
> Issue Type: Bug
> Components: cache
> Affects Versions: sprint-4
> Reporter: Valentin Kulichenko
> Assignee: Andrey Gura
> Labels: Usability
> Fix For: ignite-1.4
>
> Attachments: ignite-1016.patch, ignite-1016.patch
>
>
> These properties are currently available only for
> {{RendezvousAffinityFunction}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
