[
https://issues.apache.org/jira/browse/IGNITE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742565#comment-14742565
]
ASF GitHub Bot commented on IGNITE-708:
---------------------------------------
GitHub user murador opened a pull request:
https://github.com/apache/ignite/pull/86
IGNITE-708 remove refreshPartitions on ResendTimeoutObject
The ticket is IGNITE-708 - remove refreshPartitions on ResendTimeoutObject.
From what I could see, the refresh partition in case of timeout is
redundant, since each node has a refresh partition which runs at regular
intervals in the method body() of GridCachePartitionExchangeManager retrieved
from the background process ExchangeWorker. Thus eliminating the
refreshPartition in ResendTimeoutObject class should not have any impact on the
operation, but an increase in performance when we avoid sending redundant
message. I will proceed with the creation of a pull request. In addition I fix
several compiling error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/murador/ignite master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
----
commit a7a7e9b1703c4a8a3bcd805893f88c05af1903ae
Author: murador <[email protected]>
Date: 2015-09-13T16:51:19Z
IGNITE-708 remove refreshPartitions on ResendTimeoutObject
----
> Need to remove background partition exchange
> --------------------------------------------
>
> Key: IGNITE-708
> URL: https://issues.apache.org/jira/browse/IGNITE-708
> Project: Ignite
> Issue Type: Task
> Reporter: Yakov Zhdanov
> Assignee: Gianfranco Murador
> Priority: Blocker
> Labels: datagrid
>
> Now every node sends its partition map to cache coordinator (which is the
> oldest node in topology) and coordinator spreads full partition map to every
> node in topology. This happens for each cache separately. This seems to take
> place even if there were no changes to local partition maps. Given we
> guarantee communication message delivery this background process seems to be
> an overkill.
> Exchange should happen only if any changes took place.
> After dynamic cache start has been introduced, we can have significant amount
> of live caches at some point of app lifecycle and app may suffer from
> background exchange which is obviously not a requirement (and may be never
> has been the one).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
