[
https://issues.apache.org/jira/browse/IGNITE-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904705#comment-14904705
]
Anton Vinogradov commented on IGNITE-530:
-----------------------------------------
Thanks for your pull request.
I'd like to ask you make some changes:
1) Please refactor code according to Ignite Coding Guidelines. See
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines for
details. I recommend to configure IDEA codestyle.
2) Remove @author comments
3) Use explicit imports only.
4) other recommendations:
TwitterStreamer
Please create OAuthSetting class and use it instead of OAuth params.
Use constructor instead of setting params if possible.
I found triple check of authenticationScheme.isAssignableFrom,
duplicates should be removed.
Await of tweetStreamProcesser thread required before stopping client.
tweetStreamProcesser name contains typo.
tweetStreamProcesser's thread should be interrupted, seems infinite
wait possible at tweetQueue.take().
Catching of Throwable should be replaced by catching specific
exceptions.
finally section at stop method is not needed in case thread was
stopped before stopping client.
tweetStreamProcesser should be marked as final, so no 'is null' check
will be needed at stop method.
Switch should be used instead of this.endpointUrl.equalsIgnoreCase.
IgniteTwitterStreamerTest
Test should be runnable without providing credentials to real twitter
account. Mocked twitter server should be used.
Cache content should be checked after each TwitterStreamer use.
> Implement IgniteTwitterStreamer to stream data from Twitter feeds
> -----------------------------------------------------------------
>
> Key: IGNITE-530
> URL: https://issues.apache.org/jira/browse/IGNITE-530
> Project: Ignite
> Issue Type: Sub-task
> Components: streaming
> Reporter: Dmitriy Setrakyan
> Assignee: Lalit Kumar Jha
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under
> high load. It was previously named {{IgniteDataLoader}}, see ticket
> IGNITE-394.
> We should create {{IgniteTwitterStreamer}} which will consume messages from
> Twitter and stream them into Ignite caches.
> More details to follow, but to the least we should be able to:
> * Convert Twitter data to Ignite data using an optional pluggable converter.
> * Specify the cache name for the Ignite cache to load data into.
> * Specify other flags available on {{IgniteDataStreamer}} class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
