[
https://issues.apache.org/jira/browse/IGNITE-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936797#comment-14936797
]
Igor commented on IGNITE-1580:
------------------------------
1. Why threre is {{std::string}} used in one part of API (i.e. {{SqlQuery}}
class) when there is {{const char*}} used in other parts (i.e. {{Ignition}}
class)?
2. According to description of methods {{Get()}} and {{Start()}} they return
null in case of error. But these methods return Ignite class instances, not
pointers and only pointers in C++ can be null. So currently you can't check if
the returned Ignite instance is valid.
3. It is not necessary to annotate {{cancel}} argument of {{Stop()}} method
with {{const}} qualifier because it's passed by value.
> CPP: Review Ignition interface.
> -------------------------------
>
> Key: IGNITE-1580
> URL: https://issues.apache.org/jira/browse/IGNITE-1580
> Project: Ignite
> Issue Type: Task
> Components: interop
> Affects Versions: ignite-1.4
> Reporter: Vladimir Ozerov
> Assignee: Igor
> Priority: Critical
> Fix For: ignite-1.5
>
>
> It is necessary to review Ignition interface and understand whether it is
> compliant with common CPP practices.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
