[
https://issues.apache.org/jira/browse/IGNITE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945070#comment-14945070
]
Denis Magda commented on IGNITE-1272:
-------------------------------------
Custom class loaders won't be supported for {{PortableObject}} because it was
designed for absolutely different use cases.
It means that we can ignore/skip the rest of failing tests for
{{PortableMarshaller}} and should omit sending deployment info for caches that
store portable objects.
Currently did the following:
- set {{deploymentEnabled}} flag per {{GridCacheContext}} and
{{CacheObjectContext}};
- modified the code that used {{GridCacheSharedContext.deploymentEnabled()}} in
a way to use {{GridCacheContext.deploymentEnabled()}};
Run some basic tests. The tests are failing because not all
{{GridCacheMessages}} have properly set {{cacheId}} that is used to get a valid
{{GridCacheContext}} in some places.
So what is left is to find those message for which it's obligatory to set valid
{{cacheId}} and use it whenever it's needed.
> PortableMarshaller: issues when different class loaders are used
> ----------------------------------------------------------------
>
> Key: IGNITE-1272
> URL: https://issues.apache.org/jira/browse/IGNITE-1272
> Project: Ignite
> Issue Type: Bug
> Affects Versions: ignite-1.4
> Reporter: Denis Magda
> Assignee: Denis Magda
> Priority: Blocker
> Fix For: ignite-1.5
>
> Attachments: ignite-1272.patch
>
>
> The reason is that a loader is not passed to required places when needed.
> Reproduced with the following tests:
> - {{IgniteCacheAbstractExecutionContextTest.testUserClassLoader()}} fails
> with PortableMarshaller enabled.
> - {{GridDeploymentMessageCountSelfTest.testCacheValueDeploymentOnPut()}}
> Another issue is when {{PortableContext}} returns {{PortableClassDescriptor}}
> by type id. Returned descriptor has a constructor which already has been
> loaded with another class loader. Fix is not trivial and issue is reproduced
> with {{GridP2PRemoteClassLoadersSelfTest}}
> Look for corresponding TODOs in the code.
> Unmute tests when fixed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
