[
https://issues.apache.org/jira/browse/IGNITE-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969491#comment-14969491
]
Artem Shutak commented on IGNITE-1371:
--------------------------------------
Hi Igor,
I don't know how to use your pull-request. Could you please create pull request
from your fork to apache-ignite 'master'. In this way it could be possible to
run TC plans for your PR.
I've reviewed your patch and has next comments.
- Could you please add comments at DEVNOTES how to build cassandra module and
how to run tests. I've tried to run it from IDEA and got
{{CassandraHelper.getAdminPassword().isEmpty()==true}}, so test do nothing -
could you advice me here please (If no I will solve it by yourself, don't
worry)?
- Should I have embeded version of Cassandra or maven dependency is enought?
- I think 'logs' folder is redundant.
- It would be nice if your tests would extend {{GridAbstractTest}}. It has
start/stop grid methods, logger, hanging detection and printing stack-traces
and etc.
- Do we really need {{Serializer}} abstraction? Ignite already has
{{Marshaller}} abstraction. Will it work in this case? Or Cassandra uses
{{ByteBuffer}}s?
- About coding guidelines, you have pretty close coding style. To show what can
be fixed I created 'review' commit and you can look on it here:
https://github.com/ashutakGG/incubator-ignite/commit/9b178f1a75be6d0280dd4b14b29994a121239f67.
Also, I want to create separate TC plan for your tests. Could you advice proper
maven command.
I will continue exploring your code.
> Key-Value store (like Cassandra) as CacheStore
> ----------------------------------------------
>
> Key: IGNITE-1371
> URL: https://issues.apache.org/jira/browse/IGNITE-1371
> Project: Ignite
> Issue Type: New Feature
> Components: cache
> Affects Versions: ignite-1.4
> Reporter: Alexandre Boudnik
> Assignee: Dmitriy Setrakyan
> Attachments: master_02b59e4_ignite-1371.patch
>
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> It will provide ability to map particular cache holding POJOs to Cassandra
> table. Later it would be generalized to support eventually any any Key-Value
> store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
