[ 
https://issues.apache.org/jira/browse/IGNITE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991850#comment-14991850
 ] 

ASF GitHub Bot commented on IGNITE-1862:
----------------------------------------

GitHub user isapego opened a pull request:

    https://github.com/apache/ignite/pull/208

    IGNITE-1862: String handling in C++ fixed.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/isapego/ignite ignite-1862

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #208
    
----
commit 0cfceccddbbc5f2d1da2899322c82c59e133449f
Author: isapego <[email protected]>
Date:   2015-11-05T15:43:17Z

    IGNITE-1862: String writing fixed.

----


> CPP: Fix string handling
> ------------------------
>
>                 Key: IGNITE-1862
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1862
>             Project: Ignite
>          Issue Type: Task
>          Components: interop
>    Affects Versions: ignite-1.4
>            Reporter: Vladimir Ozerov
>            Assignee: Igor Sapego
>            Priority: Critical
>             Fix For: 1.5
>
>
> Currently we write strings using 2 bytes for each simbol. This way we are 
> trying to mimic UTF16, which is natural for Java. 
> Instead of doing this weird things, we should:
> 1) Tell user that we expect UTF8 string.
> 2) Write strings as plain char*.
> Once it is done, we will be able to remove "convertStrings" property from 
> PortableMarshaller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to