[ 
https://issues.apache.org/jira/browse/IGNITE-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000230#comment-15000230
 ] 

Denis Magda commented on IGNITE-1681:
-------------------------------------

Michael, thanks for the contribution!
I've done minor modifications related to code style, java doc, the tests and 
merged the changes onto the release branch! 

You can refer to the attached  ignite-1681-final.patch in order to pay 
attention to the code style and java doc style we follow. More info in regards 
to the styles is here:
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines

In regards to the pull-requests based contribution please follow this guide:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request

Please, next time start a title of the pull request from 'IGNITE-xxx'. It will 
trigger testing automatically. For this ticket I've done it manually.

Thanks again for the contribution!

> loadAll threshold is not configurable for CacheStoreBalancingWrapper
> --------------------------------------------------------------------
>
>                 Key: IGNITE-1681
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1681
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: ignite-1.4
>            Reporter: Alexey Goncharuk
>            Assignee: Denis Magda
>             Fix For: 1.5
>
>         Attachments: ignite-1681-final.patch
>
>
> CacheStoreBalancingWrapper is created in cache store manager using default 
> constructor. There is no way to override a default value for loadAllThreshold.
> We can add a cache configuration parameter named 
> storeConcurrentLoadAllThreshold to control this:
> {code}
> CacheConfiguration {
> ...
>     public int getStoreConcurrentLoadAllThreshold() {...}
>     public void setStoreConcurrentLoadAllThreshold(int 
> storeConcurrentLoadAllThreshold) {...}
> ...
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to