[ 
https://issues.apache.org/jira/browse/IGNITE-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003777#comment-15003777
 ] 

ASF GitHub Bot commented on IGNITE-1902:
----------------------------------------

GitHub user ptupitsyn opened a pull request:

    https://github.com/apache/ignite/pull/229

    IGNITE-1902 NET: Adopt new marshalling flags.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ptupitsyn/ignite ignite-1902

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #229
    
----
commit 351d64503b8dda4d10b1f13835c18ce134267d99
Author: Pavel Tupitsyn <ptupit...@gridgain.com>
Date:   2015-11-13T09:12:45Z

    wip header

commit 0ff80f97708f5394945489417505e432ed33766f
Author: Pavel Tupitsyn <ptupit...@gridgain.com>
Date:   2015-11-13T09:17:42Z

    wip header

commit 1e36575d7dd870b80017ad3cb349ba9468bb1854
Author: Pavel Tupitsyn <ptupit...@gridgain.com>
Date:   2015-11-13T09:20:41Z

    wip

commit 8b00aabddf8b19634423851de8e67c8f91e07adf
Author: Pavel Tupitsyn <ptupit...@gridgain.com>
Date:   2015-11-13T09:22:02Z

    Fix build

commit b0bdbd93f2407ffb6fefcd7e8802b5d530e2d871
Author: Pavel Tupitsyn <ptupit...@gridgain.com>
Date:   2015-11-13T09:33:10Z

    wip

commit 9134e1bc671a70b7fb1aa67bdfc75082ae8a21ec
Author: Pavel Tupitsyn <ptupit...@gridgain.com>
Date:   2015-11-13T09:36:47Z

    Fix flags calc

----


> NET: Adopt new marshalling flags.
> ---------------------------------
>
>                 Key: IGNITE-1902
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1902
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: interop
>    Affects Versions: ignite-1.4
>            Reporter: Vladimir Ozerov
>            Assignee: Pavel  Tupitsyn
>            Priority: Critical
>             Fix For: 1.5
>
>
> As a part of IGNITE-1816 I had to revisit our flags. Here are how they look 
> now:
> {code}
> /** Flag: user type. */
> public static final short FLAG_USR_TYP = 0x0001;
> /** Flag: schema exists. */
> public static final short FLAG_HAS_SCHEMA = 0x0002;
> /** Flag indicating that object has raw data. */
> public static final short FLAG_HAS_RAW = 0x0004;
> /** Flag: offsets take 1 byte. */
> public static final short FLAG_OFFSET_ONE_BYTE = 0x0008;
> /** Flag: offsets take 2 bytes. */
> public static final short FLAG_OFFSET_TWO_BYTES = 0x0010;
> /** Flag: compact footer, no field IDs. */
> public static final short FLAG_COMPACT_FOOTER = 0x0020;
> {code}
> The following changes must be made to NET:
> 1) When schema exists (i.e. at least on non-raw fieid was written), HAS_ 
> SCHEMA flag is set to true. This is the inversed version of what previously 
> was "RAW_ONLY".
> 2) When raw data exists, HAS_RAW flag is set to true. This flag should be 
> used to determine location of raw data. 
> *DO NOT USE % for this anymore!*
> 3) For now COMPACT_FOOTER should always be 0. If you receive an object with 
> this flag set to 1, an exception must be thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to