[
https://issues.apache.org/jira/browse/IGNITE-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denis Magda updated IGNITE-1971:
--------------------------------
Description:
Re-visit streamers implementations and should address at least the following
points below.
1) {{start}} method in streamers implementations throws
{{IllegalArgumentException}}.
According to the contract of IllegalArgumentException this exception is thrown
only when an invalid argument is passed into the function. However no argument
is passed to the method at all and we shouldn't throw this exception from this
point of execution.
My suggestion is to use org.apache.ignite.IgniteIllegalStateException if we
don't find better alternative. See how it's used in Ignite.ignite() method
description.
2) Streamers perform the same basics checks in their implementation of
{{start}} method.
It makes sense to add {{start}} method to StreamAdapter and perform there basic
checks that are the same for every streamer.
> Refactor various streamers implementations
> ------------------------------------------
>
> Key: IGNITE-1971
> URL: https://issues.apache.org/jira/browse/IGNITE-1971
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 1.5
> Reporter: Denis Magda
> Fix For: 1.6
>
>
> Re-visit streamers implementations and should address at least the following
> points below.
> 1) {{start}} method in streamers implementations throws
> {{IllegalArgumentException}}.
> According to the contract of IllegalArgumentException this exception is
> thrown only when an invalid argument is passed into the function. However no
> argument is passed to the method at all and we shouldn't throw this exception
> from this point of execution.
> My suggestion is to use org.apache.ignite.IgniteIllegalStateException if we
> don't find better alternative. See how it's used in Ignite.ignite() method
> description.
> 2) Streamers perform the same basics checks in their implementation of
> {{start}} method.
> It makes sense to add {{start}} method to StreamAdapter and perform there
> basic checks that are the same for every streamer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
