[
https://issues.apache.org/jira/browse/IGNITE-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018062#comment-15018062
]
ASF GitHub Bot commented on IGNITE-1964:
----------------------------------------
GitHub user ptupitsyn opened a pull request:
https://github.com/apache/ignite/pull/253
IGNITE-1964 .NET: Write enum type ID if possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptupitsyn/ignite ignite-1964
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #253
----
commit 55a6bf25d0a5f48e0b9b571f3e16a8d7cac8cb69
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-20T12:44:11Z
IGNITE-1964 .NET: Write enum type ID if possible.
commit 18353b540dabad20fea88dbef60f13f0281334e5
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-20T13:18:50Z
wip tests
commit 12dd21846034c29a01037c4aa1ef3d927443bcfb
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-20T13:23:18Z
wip tests
commit a962331c210511454f8c6e739e9a6e4cdbf52963
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-20T13:30:25Z
Test created
commit 43839176408021519616929af81c323e094953b0
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-20T13:41:20Z
Merge remote-tracking branch 'remotes/upstream/ignite-1282' into ignite-1964
commit bae0304659dda4fe98ec141394ba1affd45ab95e
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-20T13:54:12Z
Fix test
commit 04fa262089e825fbb1831088b30e85fc6692ced8
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-20T14:02:47Z
Cleanup
----
> .NET: Write enum type ID if possible.
> -------------------------------------
>
> Key: IGNITE-1964
> URL: https://issues.apache.org/jira/browse/IGNITE-1964
> Project: Ignite
> Issue Type: Sub-task
> Components: interop
> Affects Versions: ignite-1.4
> Reporter: Vladimir Ozerov
> Assignee: Pavel Tupitsyn
> Priority: Critical
> Fix For: 1.5
>
>
> Currently we always write -1 as enum type ID in .NET. We made this for two
> reasons:
> 1) .NET has fair generics and always has necessary type info to perform
> deserialization.
> 2) We do not have dynamic portable type register as in Java yet.
> However, this approach make it impossible to interoperate with Java when
> context cannot be inferred. E.g. in queries.
> Full solution:
> 1) Implement dynamic types register.
> 2) Always pass Enum type ID.
> Solution require in scope of this ticket due to tight release schedule:
> 1) Pass enum type ID when possible, i.e. when enum is restered as portable
> type explicitly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
