[ 
https://issues.apache.org/jira/browse/IGNITE-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026415#comment-15026415
 ] 

Denis Magda commented on IGNITE-1544:
-------------------------------------

Andrey, I have the following comments so far:

1. Let's go further and remove {{GridCacheAdapter.primarySize()}} or make it 
return {{long}} by default. Since it's the internal API I don't see any reason 
why we need to introduce {{primarySizeLong}} counterpart;

2. {{GridCacheAdapter.sizeAsync}} and {{GridCacheAdapter.sizeLongAsync}} 
method's implementation body is the same. The only difference is that one uses 
{{SizeTask}} while the other - {{SizeLongTask}}. I suggest moving common part 
of the implementations in a special private method which will accept a size 
task as a parameter.

3. In the newly added java docs there is the sentence like this - "Gets the 
number of all entries cached on this node as a long". Please end such sentences 
with "as a long value" instead. 

> Make sure objects number stored in a cache can be bigger than 
> Integer.MAX_VALUE
> -------------------------------------------------------------------------------
>
>                 Key: IGNITE-1544
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1544
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: ignite-1.4
>            Reporter: Denis Magda
>            Assignee: Denis Magda
>            Priority: Critical
>             Fix For: 1.5
>
>
> Make sure that a cache (partitioned) can actually hold number of objects 
> bigger than {{Integer.MAX_VALUE}}. Because {{Integer.MAX_VALUE}} is not 
> enough for some life use cases and business domains.
> At least the following should be done:
> - IgniteCache must return cache size as a {{long}} value;
> - Make sure (make a test) that a partitioned cache can store number of 
> objects much bigger than {{Integer.MAX_VALUE}};
> - find and edit info regarding this limitation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to