[
https://issues.apache.org/jira/browse/IGNITE-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029038#comment-15029038
]
Romain Gilles edited comment on IGNITE-1270 at 11/26/15 4:14 PM:
-----------------------------------------------------------------
Hi Raoul,
{quote}
Why don't you use the parent child classloader delegation?
Because in OSGi, classloaders are connected in a graph fashion, not in a tree
pattern. The parent classloader is useless here.
{quote}
For me having graph fashion does not prevent you to use a parent ;). But if it
works like that I'm ok with that.
h4. Maven
What I like with this approach it's it give you a clear technical (third party)
BOM ;) You can see the size of your overall dep and so on. But if you don't
like have no issue with that it is just a point of view.
was (Author: rogilles):
Hi Raoul,
{quote}
Why don't you use the parent child classloader delegation?
Because in OSGi, classloaders are connected in a graph fashion, not in a tree
pattern. The parent classloader is useless here.
{quote}
For me having graph fashion does not prevent you to use a parent ;). But if it
works like that I'm ok with that.
h4. ContainerSweepClassLoader
Here what I think will be an issue is the state check in the bundle and if they
are fragments. Because I think end user will end up with this issue:
{quote}
You should also take care of the bundle state before requesting the class
loading as only at least RESOLVED bundles have a class loader.
There is also a problem with fragment with an exception maybe you can skip
fragments.
If you call loadClass on an INSTALLED it will attempt to resolve and I'm not
sure this is what the end user want.
If you call it on un UNSTALLED then exception.
This may impact the sweepContainer(..) method and the return
resolved.get(name).loadClass(name); block of code.
{quote}
h4. Maven
What I like with this approach it's it give you a clear technical (third party)
BOM ;) You can see the size of your overall dep and so on. But if you don't
like have no issue with that it is just a point of view.
> Basic OSGi support for Ignite
> -----------------------------
>
> Key: IGNITE-1270
> URL: https://issues.apache.org/jira/browse/IGNITE-1270
> Project: Ignite
> Issue Type: New Feature
> Components: general, osgi
> Reporter: Raúl Kripalani
> Assignee: Raúl Kripalani
> Fix For: 1.5
>
>
> Basics for a first iteration:
> * Manifest creation for all Java-based modules.
> * Apache Karaf features file to facilitate deployment (along with
> dependencies).
> * Make Ignite classloading OSGi-friendly and support different strategies.
> Future:
> * Support peer class-loading.
> * Potentially support remote 3rd dependency class-loading for Apache Karaf
> (via Pax Mvn URL and Aether, one can fetch a bundle from Maven repositories).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
