[
https://issues.apache.org/jira/browse/IGNITE-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037668#comment-15037668
]
Yakov Zhdanov commented on IGNITE-1270:
---------------------------------------
Raul,
I did a quick review and spotted several issues (mostly code style related
since I have no real world experience with osgi). I committed my changes to
ignite-1270. Please review them.
* lifecycle methods are private, e.g.
org.apache.ignite.osgi.IgniteAbstractOsgiContextActivator#postStop. I think you
want making them protected.
* IgniteOsgiTestSuite fails for me locally. Am I doing anything wrong?
* In Ignite we usually name lifecycle methods starting with "on". Can you
please rename activator methods accordingly - onBefore/After/Stop()... I also
think it is good idea to add test for making sure lifecycle methods get called
as expected.
* should we also call lifecycle methods (esp onAfterStop()) even in case
exception is thrown inside activator code? I think we should since some
critical cleanup logic may reside there.
* please fix your auto-imports in IDE -
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-PackageImporting
* no need to define group id in poms since it is defined in parent pom
* No need to use string buffer in plain expression -
org/apache/ignite/osgi/classloaders/BundleDelegatingClassLoader.classNotFoundException:139
since readability suffers, I think.
Thanks!
> Basic OSGi support for Ignite
> -----------------------------
>
> Key: IGNITE-1270
> URL: https://issues.apache.org/jira/browse/IGNITE-1270
> Project: Ignite
> Issue Type: New Feature
> Components: general, osgi
> Reporter: Raúl Kripalani
> Assignee: Raúl Kripalani
> Fix For: 1.6
>
>
> Basics for a first iteration:
> * Manifest creation for all Java-based modules.
> * Apache Karaf features file to facilitate deployment (along with
> dependencies).
> * Make Ignite classloading OSGi-friendly and support different strategies.
> Future:
> * Support peer class-loading.
> * Potentially support remote 3rd dependency class-loading for Apache Karaf
> (via Pax Mvn URL and Aether, one can fetch a bundle from Maven repositories).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
