[ 
https://issues.apache.org/jira/browse/IGNITE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048824#comment-15048824
 ] 

ASF GitHub Bot commented on IGNITE-1993:
----------------------------------------

GitHub user westbury opened a pull request:

    https://github.com/apache/ignite/pull/309

    IGNITE-1993 remove non-standard SQL clause so table for JDBC discovery…

    Note that the tests do not run locally.  They fail because portable/test1 
and portable/test2 are not available (see IGNITE-1462).  However I note that 
the instructions at 
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute instruct 
to use -DskipTests so I did that.
    
    This pull request supercedes the patch as per Denis Magda's comment.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/westbury/ignite ignite-1993

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #309
    
----
commit e8088e92e409eff80c6622cda55201c6719abe4e
Author: Nigel Westbury <[email protected]>
Date:   2015-12-09T14:49:36Z

    IGNITE1993 remove non-standard SQL clause so table for JDBC discovery works 
in Oracle

----


> JDBC discovery uses non-standard SQL when creating table (not compatible with 
> Oracle)
> -------------------------------------------------------------------------------------
>
>                 Key: IGNITE-1993
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1993
>             Project: Ignite
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: ignite-1.4
>         Environment: Oracle database
>            Reporter: Nigel Westbury
>              Labels: easyfix, patch
>             Fix For: 1.4
>
>         Attachments: IGNITE1993.patch
>
>
> The SQL used by TcpDiscoveryJdbcIpFinder to create the table (defined by 
> CREATE_ADDRS_TABLE_QRY) uses 'if not exists' clause.  However this clause is 
> not supported by Oracle and causes SQLSyntaxErrorException: "ORA-00922: 
> missing or invalid option" to be thrown.  This prevents JDBC discovery from 
> being used with an Oracle database.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to