[
https://issues.apache.org/jira/browse/IGNITE-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067859#comment-15067859
]
Denis Magda commented on IGNITE-2016:
-------------------------------------
Hi Roman, before taking look at the details of the implementation I have
several high level questions.
- In general as I see you've implemented a new Kafka streamer using Kafka
Connect API, correct?
If so is there any reason why we can't extend existed {{StreamAdapter}} like
current Ignite's {{KafkaStreamer}}, {{MqttStreamer}}, etc. does? It will be
more consistent if you create a kind of {{KafkaConnectStreamer}} and put all
the implementation details in there.
- I wouldn't mode create one more module cause we already have "ignite-kafka".
So my preference if you reuse the existed one.
- New streamer's configuration parameters should be passed through setters of
the implementation. Please refer to {{KafkaStreamer}}, {{MqttStreamer}} to as
an example.
> Update KafkaStreamer to fit new features introduced in Kafka 0.9
> ----------------------------------------------------------------
>
> Key: IGNITE-2016
> URL: https://issues.apache.org/jira/browse/IGNITE-2016
> Project: Ignite
> Issue Type: New Feature
> Components: streaming
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> Particularly,
> - new consumer
> - Kafka Connect (Copycat)
> http://www.confluent.io/blog/apache-kafka-0.9-is-released
> This can be a a different integration task or a complete re-write of the
> current implementation, considering the fact that Kafka Connect is a new
> standard way for "large-scale, real-time data import and export for Kafka."
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
