[
https://issues.apache.org/jira/browse/IGNITE-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073720#comment-15073720
]
Denis Magda commented on IGNITE-944:
------------------------------------
Hi Saikat,
Thanks a lot for contributions!
I've left my general review notes directly on GitHub using comments block.
Please take a look and address them
https://github.com/apache/ignite/pull/383/files
In addition please do the following:
- Add your {{GridLogCommandHandlerTest}} to existed
{{IgniteRestHandlerTestSuite}};
- After you apply review notes and all the tests are passed move this ticket to
"Patch Available" state as it specified at the end of this section [1]
- Follow our coding guidelines (spaces, docs, var names) [2]
[1]
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request
[2] https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
> HTTP REST log command doesn't work
> ----------------------------------
>
> Key: IGNITE-944
> URL: https://issues.apache.org/jira/browse/IGNITE-944
> Project: Ignite
> Issue Type: Bug
> Components: general, newbie
> Affects Versions: sprint-5
> Reporter: Sergey Kozlov
> Assignee: Saikat Maitra
>
> Request http://localhost:8080/ignite?cmd=log&to=1&from=0 returns following
> {noformat}
> {"error":"Failed to find registered handler for command:
> LOG","response":null,"sessionToken":"","successStatus":1}
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
