[
https://issues.apache.org/jira/browse/IGNITE-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074811#comment-15074811
]
Vladimir Ozerov edited comment on IGNITE-2263 at 12/30/15 9:06 AM:
-------------------------------------------------------------------
Yes, I am not going to remove these methods blindly. Instead, every usage
should be analyzed. In some places F.view is not a problem because it is either
used correctly or is not on a hot path. In other places it could degrade
performance. E,g., there is a hot place in code where we take a collection,
then split it into two parts using F.view(), and a a few moments later we merge
it back using F.concat().
So it all depends.
was (Author: vozerov):
Yes, I am not going to remove these methods blindly. Instead, every usage
should be analyzed. In some places F.view is not a problem because it is either
used correctly or is not on a hot path. In other places it could degrade
performance. E,g., there is a hot place in code where we take a collection,
then split it into two parts using F.view() a few moments later we merge it
back using F.concat().
So it all depends.
> Get rid of wrapping views where possible.
> -----------------------------------------
>
> Key: IGNITE-2263
> URL: https://issues.apache.org/jira/browse/IGNITE-2263
> Project: Ignite
> Issue Type: Sub-task
> Components: general
> Affects Versions: ignite-1.4
> Reporter: Vladimir Ozerov
> Assignee: Vladimir Ozerov
> Priority: Critical
> Fix For: 1.6
>
>
> We have about ~50-100 usages of things like F.view or F.viewReadOnly. In lots
> cases it is not necessary, adds garbage, but doesn't add any value.
> Need to revisit these places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
