[ 
https://issues.apache.org/jira/browse/IGNITE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116894#comment-15116894
 ] 

Denis Magda commented on IGNITE-2231:
-------------------------------------

Yes, this is correct.

However you have to check all the test suites cause you changed core 
functionality that can affect many modules.
You can start all the tests this way:
1) Open this page that shows which test suites were checked against your 
pull-request
http://204.14.53.153/project.html?projectId=IgniteTests&branch_IgniteTests=pull%2F425%2Fhead

2) Look for "Run All" row at the top and press "Run" button that it to the 
left. You should see that all the tests were scheduled to be checked against 
your pull-request

> 'Put' cache event treats entry created at lock acquisition time as old value
> ----------------------------------------------------------------------------
>
>                 Key: IGNITE-2231
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2231
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: ignite-1.4
>            Reporter: Denis Magda
>            Assignee: wmz7year
>              Labels: important
>             Fix For: 1.6
>
>         Attachments: EventsProcessingTest.java
>
>
> Subscribe for EVT_CACHE_OBJECT_PUT event on one node and perform 'put' 
> operations from the other to an empty transnational cache.
> The subscriber will receive a notification saying that there was an old value 
> for a key at the time the new was being inserted. In fact the was no an old 
> value, the entry with a {{null}} as a value was generated as a part of 
> implicit lock acquisition.
> This snippet of the code in {{GridCacheMapEntry}} generates a wrong event 
> (innerSet function)
> {noformat}
>             if (evt && newVer != null && 
> cctx.events().isRecordable(EVT_CACHE_OBJECT_PUT)) {
>                 CacheObject evtOld = cctx.unwrapTemporary(old);
>                 cctx.events().addEvent(partition(),
>                     key,
>                     evtNodeId,
>                     tx == null ? null : tx.xid(),
>                     newVer,
>                     EVT_CACHE_OBJECT_PUT,
>                     val,
>                     val != null,
>                     evtOld,
>                     evtOld != null || hasValueUnlocked(),
>                     subjId, null, taskName,
>                     keepBinary);
>             }
> {noformat}
> Attached the test that lets reproduce the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to