[
https://issues.apache.org/jira/browse/IGNITE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121568#comment-15121568
]
ASF GitHub Bot commented on IGNITE-1759:
----------------------------------------
GitHub user ptupitsyn opened a pull request:
https://github.com/apache/ignite/pull/437
IGNITE-1759 .Net: Make guid read/write platform-safe.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptupitsyn/ignite ignite-1759
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #437
----
commit 52698b17068475536752c9ec9e6cc0a36b18ebaa
Author: ptupitsyn <[email protected]>
Date: 2015-10-21T17:28:47Z
wip todos
commit 77132979501ba32f27cc31f35bdedee1ddaa3486
Author: ptupitsyn <[email protected]>
Date: 2015-10-22T09:04:10Z
Endianness issue fixed
commit d5173706035a45936993902156198c41f88b8ce6
Author: ptupitsyn <[email protected]>
Date: 2015-10-22T09:41:20Z
WriteGuidBytewise
commit 3996dc01e3fbf05ceebc25d5a8a04ec977bc5ec6
Author: ptupitsyn <[email protected]>
Date: 2015-10-22T10:07:12Z
wip
commit 022300a1421359d57a598189f91787fd62532b47
Author: ptupitsyn <[email protected]>
Date: 2015-10-22T10:09:34Z
GetIsGuidSequentialPacked improved check
commit 6733894c879bf139002a4340858f7979ca48d16b
Author: ptupitsyn <[email protected]>
Date: 2015-10-22T10:11:24Z
wip
commit ddc5fc4c3f2f1425c39f0692c2d29c43d7239ef4
Author: ptupitsyn <[email protected]>
Date: 2015-10-22T10:11:59Z
Merge remote-tracking branch 'remotes/upstream/ignite-1282' into ignite-1759
commit fb490ba6e9a01ebeb404a54ac3f2b8bbeaaa70d8
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-11T10:46:02Z
Merge remote-tracking branch 'remotes/upstream/ignite-1282' into ignite-1759
Conflicts:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryUtils.cs
commit a4da6b3d06728bbd0ece6ce613d438151220ed58
Author: Pavel Tupitsyn <[email protected]>
Date: 2015-11-11T10:46:11Z
fix merge
commit b1747a4efa03f9d7d137a3336f5451eb694f2781
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-01-28T14:17:05Z
Merge remote-tracking branch 'remotes/upstream/master' into ignite-1759
commit b843c175deedb41906e047fcd1fa9da5ae1be965
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-01-28T14:20:53Z
renaming
commit 30acdff64d8b86cd0846779acd28c4db0be34c43
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-01-28T14:27:21Z
Unit test added
----
> .Net: Guid read/write is not platform-safe.
> -------------------------------------------
>
> Key: IGNITE-1759
> URL: https://issues.apache.org/jira/browse/IGNITE-1759
> Project: Ignite
> Issue Type: Bug
> Components: platforms
> Affects Versions: ignite-1.4
> Reporter: Vladimir Ozerov
> Assignee: Pavel Tupitsyn
> Priority: Critical
> Fix For: 1.6
>
>
> Two problems here:
> 1) We do not count for endiannes, so byte shifts might be invalid.
> 2) Guid doesn't have fixed layout. For this reason there are no guarantees
> that it will take 16 bytes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
