[ 
https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140603#comment-15140603
 ] 

Anton Vinogradov commented on IGNITE-2555:
------------------------------------------

Konstantin,

I see you changed IgniteKernal, one of the main classes at Apache Ignite.
So, you need to find or write test covers your changes. Did you use existing 
test to check your changes?
We have to ensure that changes brings no NullPointerException or something like 
that. 
I recomend you to run all cache suites, and suits contains tests that covers 
changes.


> Include offheap usage in metrics report
> ---------------------------------------
>
>                 Key: IGNITE-2555
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2555
>             Project: Ignite
>          Issue Type: Task
>    Affects Versions: 1.5.0.final
>            Reporter: Sergey Kozlov
>            Assignee: Konstantin Margorin
>            Priority: Minor
>              Labels: newbie
>
> The local node prints out the set of key parameters in its log (or console). 
> It makes sense to add offheap usage (used/free/committed) to that report.
> {noformat}
> Metrics for local node (to disable set 'metricsLogFrequency' to 0)
>     ^-- Node [id=41b12e0f, name=null]
>     ^-- H/N/C [hosts=1, nodes=14, CPUs=8]
>     ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%]
>     ^-- Heap [used=1364MB, free=27,44%, comm=1881MB]
>     ^-- Public thread pool [active=0, idle=16, qSize=0]
>     ^-- System thread pool [active=1, idle=15, qSize=0]
>     ^-- Outbound messages queue [size=0]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to