[
https://issues.apache.org/jira/browse/IGNITE-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162793#comment-15162793
]
ASF GitHub Bot commented on IGNITE-2584:
----------------------------------------
GitHub user ilantukh opened a pull request:
https://github.com/apache/ignite/pull/511
IGNITE-2584
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilantukh/ignite ignite-2584
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/511.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #511
----
commit 49f82e62d98ea5f057c0b69fbb40cff942e52599
Author: Ilya Lantukh <[email protected]>
Date: 2016-02-24T10:02:41Z
ignite-2584 : Changed part2node value type to list.
commit f70dcdd5b4713a880153e2f1aae22126e2f33964
Author: Ilya Lantukh <[email protected]>
Date: 2016-02-24T10:34:23Z
ignite-2584 : Fixed comments.
----
> Investigate whether GridDhtPartitionTopologyImpl.part2Node could have List as
> value.
> ------------------------------------------------------------------------------------
>
> Key: IGNITE-2584
> URL: https://issues.apache.org/jira/browse/IGNITE-2584
> Project: Ignite
> Issue Type: Sub-task
> Components: cache
> Affects Versions: 1.5.0.final
> Reporter: Vladimir Ozerov
> Assignee: Ilya Lantukh
> Fix For: 1.6
>
>
> *Problem*
> "GridDhtPartitionTopologyImpl.part2Node" has value of type Set<UUID>.
> However, set semantics is almost never used except of node leave events which
> are pretty rate.
> Iterations over this Set require instantiation of iterators. This could be
> avoided if we replace HashSet with ArrayList.
> *Proposed solution*
> 1) Investigate whether Set "unique" semantics is exploited anywhere.
> 2) Investigate whether HashSet.get() O(1) is exploited on hot paths.
> 3) If neither p.1 nor p.2 hold - replace HashSet with ArrayList and change
> corresponding foreach-loops to counted for-loops.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
