[
https://issues.apache.org/jira/browse/IGNITE-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166318#comment-15166318
]
Alexey Stelmak commented on IGNITE-2560:
----------------------------------------
- ??for me all new tests fail with error??... fixed.
- ??can not find changes for local/atomic cache??.... done.
- ??I think it makes sense to add flag 'entryProcessorAnnotations' in
GridResourceIoc.ClassDescriptor to avoid extra checks on each 'invoke' call
(and remove method 'isAnnotationsPresent' you added)??... done, but implemented
differently (see 'isAnnotationsPresent')
- ??need to add tests for both methods 'invokeAll(Map map)' and 'invokeAll(Set
keys, EntryProcessor entryProcessor)' and check in tests all supported
annotations??... done (GridCacheAbstractFullApiSelfTest and
GridTransformSpringInjectionSelfTest)
- ??need test all transaction types and not only case when tx is rolled back,
also for tx cache need check case without starting explicit transaction (just
'cache.invoke' outside of IgniteTransactions.start()/commit)??... done.
- ??please change exception thrown by EntryProcessorResourceInjectorProxy:
'throw new RuntimeException(e)' -> 'throw new IgniteException("Failed to inject
entry processor resources', e);'??... done.
- ??inside GridCacheMapEntry.innerGet0 and innerUpdate entry processor class
name is passed to EVT_CACHE_OBJECT_READ, when proxy is used then original entry
processor class name is lost, need to fix this and add test??... done.
> Support injections in entry processors
> --------------------------------------
>
> Key: IGNITE-2560
> URL: https://issues.apache.org/jira/browse/IGNITE-2560
> Project: Ignite
> Issue Type: Improvement
> Components: cache
> Reporter: Valentin Kulichenko
> Assignee: Alexey Stelmak
> Fix For: 1.6
>
>
> Currently resources are not injected in entry processor, which is not
> consistent with other functionality, like closures, jobs, listeners, etc.
> To avoid performance degradation we should introspect the class only once,
> cache this information and do not try to inject if there are no annotations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
