[ 
https://issues.apache.org/jira/browse/IGNITE-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167085#comment-15167085
 ] 

Vladimir Ozerov edited comment on IGNITE-2523 at 2/25/16 11:09 AM:
-------------------------------------------------------------------

Ilya, here are my comments:
1) GridCacheIoManager: messages are processed incorrectly. See {{case -23}} for 
correct handling - every message must have unique ID.
2) GridDhtAtomicUpdateFuture: I think you cannot decide which DHT request type 
to pick based on NEAR request type. What if primary node is of new version, 
while backup nodes are still using <1.6?
3) General: unused imports
4) General: missing docs for methods and fields.


was (Author: vozerov):
Ilya, here are my comments:
1) GridCacheIoManager: messages are processed incorrectly. See {{case -23}} for 
correct handling - every message must have unique ID.
2) GridDhtAtomicUpdateFuture: I think you cannot decide which DHT request type 
to pick based on NEAR request type. What if single request
3) General: unused imports
4) General: missing docs for methods and fields.

> Introduce "single put" NEAR update request.
> -------------------------------------------
>
>                 Key: IGNITE-2523
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2523
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: cache
>    Affects Versions: 1.5.0.final
>            Reporter: Vladimir Ozerov
>            Assignee: Ilya Lantukh
>             Fix For: 1.6
>
>
> Essentially, in this case we could get rid of all collections and garbage 
> inside GridNearAtomicUpdateRequest/GridDhtAtomicUpdateRequest.
> This should drastically decrease message size and improve performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to