[
https://issues.apache.org/jira/browse/IGNITE-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104184#comment-17104184
]
Ivan Pavlukhin commented on IGNITE-12976:
-----------------------------------------
[~Kostyuckovich], the fix itself looks good. But there is a couple of moments
specific to Ignite development process which should be addressed:
# Each test class should be added to a test suite to run in CI. Here you can
use
https://github.com/apache/ignite/blob/master/modules/spring-data/src/test/java/org/apache/ignite/testsuites/IgniteSpringDataTestSuite.java
(and counterparts for different spring-data versions).
# Usually patches should be checked with TC bot (https://mtcga.gridgain.com/),
check an
[instruction|https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot#ApacheIgniteTeamcityBot-HowtocheckaPRwiththeTCBot].
Do not hesitate to ask if something is not clear.
> Invalid SQL syntax for NULLS LAST / NULLS FIRST in IgniteQueryGenerator
> -----------------------------------------------------------------------
>
> Key: IGNITE-12976
> URL: https://issues.apache.org/jira/browse/IGNITE-12976
> Project: Ignite
> Issue Type: Bug
> Components: spring
> Affects Versions: 2.8
> Reporter: Mikhail Kostyuckovich
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Ignite Spring Data's {{IgniteQueryGenerator}} (in all {{spring-data}} /
> {{spring-data-2.0}} / {{spring-data-2.2}} modules) generate invalid SQL when
> null handling other than native is used.
> Currently generated query - invalid:
> {{SELECT ... ORDER BY ... NULL FIRST ...}}
> {{SELECT ... ORDER BY ... NULL LAST ...}}
> Expected - valid:
> {{SELECT ... ORDER BY ... NULL*S* FIRST ...}}
> {{SELECT ... ORDER BY ... NULL*S* LAST ...}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
