[
https://issues.apache.org/jira/browse/IGNITE-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125451#comment-17125451
]
Igor Sapego edited comment on IGNITE-13078 at 6/4/20, 9:23 AM:
---------------------------------------------------------------
[~ivandasch]
Checked it on CentOS 7 and Windows with CLion and msvc 14.1 . See my comments
below:
# Let's change minimal required version for Boost. Now it is set to 1.56 but
CentOS's 7 default is 1.53 and everything works just fine with it.
# We try to link ODBC driver to odbcinst but this is only component of
unixODBC. There is no such library on Windows, nor when iODBC is used AFAIK.
Need to add a check. Also, why don't we link {{$\{ODBC_LIBRARIES}}} provided by
FindOBDC? Maybe it will add odbcinst without need to add it manually?
# I'm not sure, how will it work in binary package, where some of the
directories are missing (like tests). Have anyone tested it?
# FindODBC which is included in project is licensed with BSD License. Is it
compatible with Apache License?
By the way, I faced some compilation errors when building with msvc 14.1 on
Windows. Filed a ticked: IGNITE-13116
I'm also planning to do some more testing on Windows with tests. Will keep you
posted.
was (Author: isapego):
[~ivandasch]
Checked it on CentOS 7 and Windows with CLion and msvc 15. See my comments
below:
# Let's change minimal required version for Boost. Now it is set to 1.56 but
CentOS's 7 default is 1.53 and everything works just fine with it.
# We try to link ODBC driver to odbcinst but this is only component of
unixODBC. There is no such library on Windows, nor when iODBC is used AFAIK.
Need to add a check. Also, why don't we link {{$\{ODBC_LIBRARIES}}} provided by
FindOBDC? Maybe it will add odbcinst without need to add it manually?
# I'm not sure, how will it work in binary package, where some of the
directories are missing (like tests). Have anyone tested it?
# FindODBC which is included in project is licensed with BSD License. Is it
compatible with Apache License?
By the way, I faced some compilation errors when building with msvc 15 on
Windows. Filed a ticked: IGNITE-13116
I'm also planning to do some more testing on Windows with tests. Will keep you
posted.
> С++: Add CMake build support
> ----------------------------
>
> Key: IGNITE-13078
> URL: https://issues.apache.org/jira/browse/IGNITE-13078
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
> Reporter: Ivan Daschinskiy
> Assignee: Ivan Daschinskiy
> Priority: Major
> Fix For: 2.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, it is hard to build Ignite.C++. Different build process for
> windows and linux, lack of building support on Mac OS X (quite popular OS
> among developers), absolutely not IDE support, except windows and only Visual
> Studio is supported.
> I’d suggest to migrate to CMake build system. It is very popular among open
> source projects, and in Apache Software Foundation too. Notable user: Apache
> Mesos, Apache Zookeeper (C client offers CMake as an alternative to autoconf
> and only option on windows), Apache Kafka (librdkafka - C/C++ client), Apache
> Thrift. Popular column-oriented database ClickHouse also uses CMake.
> CMake is widely supported in many IDE’s on various platforms, notably Visual
> Studio, CLion, Xcode, QtCreator, KDevelop.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
