[
https://issues.apache.org/jira/browse/IGNITE-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143337#comment-17143337
]
Ignite TC Bot commented on IGNITE-13012:
----------------------------------------
{panel:title=Branch: [pull/7835/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7835/head] Base: [master] : New Tests
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=1ecde8ca-c835-40f0-84b5-5f120652fb34, topVer=0,
nodeId8=79b4c8bd, msg=, type=NODE_JOINED, tstamp=1592922924152],
val2=AffinityTopologyVersion [topVer=-8557124388581407890, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=1ecde8ca-c835-40f0-84b5-5f120652fb34, topVer=0,
nodeId8=79b4c8bd, msg=, type=NODE_JOINED, tstamp=1592922924152],
val2=AffinityTopologyVersion [topVer=-8557124388581407890, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=c74ea91e271-8b81e6bf-0900-4345-acaf-b97f401e49ba, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=60097310-0e55-46a9-a3f4-d4ba4e0302fc, topVer=0, nodeId8=60097310,
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1592922924152]],
val2=AffinityTopologyVersion [topVer=-5196826382153774944, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=c74ea91e271-8b81e6bf-0900-4345-acaf-b97f401e49ba, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=60097310-0e55-46a9-a3f4-d4ba4e0302fc, topVer=0, nodeId8=60097310,
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1592922924152]],
val2=AffinityTopologyVersion [topVer=-5196826382153774944, minorTopVer=0]]] -
PASSED{color}
{color:#00008b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=b4b39a84-6c25-448d-89ea-3eccee841eac, topVer=0,
nodeId8=e5615957, msg=, type=NODE_JOINED, tstamp=1592923013555],
val2=AffinityTopologyVersion [topVer=-3939455393161335600, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=b4b39a84-6c25-448d-89ea-3eccee841eac, topVer=0,
nodeId8=e5615957, msg=, type=NODE_JOINED, tstamp=1592923013555],
val2=AffinityTopologyVersion [topVer=-3939455393161335600, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=f91e5a1e271-baed6732-c5c9-4be1-9fab-4390a574bd30, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=b7fe7817-4e52-460f-b0ff-f2537b5f2845, topVer=0, nodeId8=b7fe7817,
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1592923013555]],
val2=AffinityTopologyVersion [topVer=-5941968585139194205, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=f91e5a1e271-baed6732-c5c9-4be1-9fab-4390a574bd30, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=b7fe7817-4e52-460f-b0ff-f2537b5f2845, topVer=0, nodeId8=b7fe7817,
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1592923013555]],
val2=AffinityTopologyVersion [topVer=-5941968585139194205, minorTopVer=0]]] -
PASSED{color}
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5412147&buildTypeId=IgniteTests24Java8_RunAll]
> Fix failure detection timeout. Simplify node ping routine.
> ----------------------------------------------------------
>
> Key: IGNITE-13012
> URL: https://issues.apache.org/jira/browse/IGNITE-13012
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.8.1
> Reporter: Vladimir Steshin
> Assignee: Vladimir Steshin
> Priority: Major
> Labels: iep-45
> Attachments: IGNITE-13012-patch.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Connection failure may not be detected within
> IgniteConfiguration.failureDetectionTimeout. Actual worst delay is:
> ServerImpl.CON_CHECK_INTERVAL + IgniteConfiguration.failureDetectionTimeout.
> Node ping routine is duplicated.
> We should fix:
> 1. Failure detection timeout should take in account last sent message.
> Current ping is bound to own time:
> {code:java}ServerImpl. RingMessageWorker.lastTimeConnCheckMsgSent{code}
> This is weird because any discovery message check connection.
> 2. Make connection check interval depend on failure detection timeout (FTD).
> Current value is a constant:
> {code:java}static int ServerImpls.CON_CHECK_INTERVAL = 500{code}
> 3. Remove additional, quickened connection checking. Once we do fix 1, this
> will become even more useless.
> Despite TCP discovery has a period of connection checking, it may send ping
> before this period exhausts. This premature ping relies also on the time of
> any received message for some reason.
> 4. Do not worry user with “Node seems disconnected” when everything is OK.
> Once we do fix 1 and 3, this will become even more useless.
> Node may log on INFO: “Local node seems to be disconnected from topology …”
> whereas it is not actually disconnected at all.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
