[ 
https://issues.apache.org/jira/browse/IGNITE-13016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148825#comment-17148825
 ] 

Ignite TC Bot commented on IGNITE-13016:
----------------------------------------

{panel:title=Branch: [pull/7838/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7838/head] Base: [master] : New Tests 
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=63e53550371-b7bbaed4-9174-4bd0-832e-86bb88791e4f, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=f8d1a9be-a5ec-4dee-8c71-dbb945007756, topVer=0, nodeId8=f8d1a9be, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593522216498]], 
val2=AffinityTopologyVersion [topVer=479273715644047619, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=d429993e-eff2-4659-bdf9-4bed09fca199, topVer=0, 
nodeId8=1eff0d87, msg=, type=NODE_JOINED, tstamp=1593522216498], 
val2=AffinityTopologyVersion [topVer=4418461583898486663, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=d429993e-eff2-4659-bdf9-4bed09fca199, topVer=0, 
nodeId8=1eff0d87, msg=, type=NODE_JOINED, tstamp=1593522216498], 
val2=AffinityTopologyVersion [topVer=4418461583898486663, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=63e53550371-b7bbaed4-9174-4bd0-832e-86bb88791e4f, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=f8d1a9be-a5ec-4dee-8c71-dbb945007756, topVer=0, nodeId8=f8d1a9be, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593522216498]], 
val2=AffinityTopologyVersion [topVer=479273715644047619, minorTopVer=0]]] - 
PASSED{color}

{color:#00008b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=ac7fbe8c-3709-480f-8a9b-a17e9cb4e307, topVer=0, 
nodeId8=5a4dfb3a, msg=, type=NODE_JOINED, tstamp=1593522268422], 
val2=AffinityTopologyVersion [topVer=1174591130455611368, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=ac7fbe8c-3709-480f-8a9b-a17e9cb4e307, topVer=0, 
nodeId8=5a4dfb3a, msg=, type=NODE_JOINED, tstamp=1593522268422], 
val2=AffinityTopologyVersion [topVer=1174591130455611368, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=d6a6e550371-c62106f4-0bc0-4061-b0c1-735533169ef7, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=90c60780-81e5-40b9-ae84-eb7166a59ae5, topVer=0, nodeId8=90c60780, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593522268422]], 
val2=AffinityTopologyVersion [topVer=110843890637889783, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=d6a6e550371-c62106f4-0bc0-4061-b0c1-735533169ef7, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=90c60780-81e5-40b9-ae84-eb7166a59ae5, topVer=0, nodeId8=90c60780, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593522268422]], 
val2=AffinityTopologyVersion [topVer=110843890637889783, minorTopVer=0]]] - 
PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5430065&buildTypeId=IgniteTests24Java8_RunAll]

> Fix backward checking of failed node.
> -------------------------------------
>
>                 Key: IGNITE-13016
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13016
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Vladimir Steshin
>            Assignee: Vladimir Steshin
>            Priority: Major
>              Labels: iep-45
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Backward node connection checking looks wierd. What might be improved are:
> 1) Addresses checking could be done in parrallel, not serializably
> {code:java}
> for (InetSocketAddress addr : nodeAddrs) {
>     // Connection refused may be got if node doesn't listen
>     // (or blocked by firewall, but anyway assume it is dead).
>     if (!isConnectionRefused(addr)) {
>         liveAddr = addr;
>         break;
>         }
> }
> {code}
> 2) Any io-exception should be considered as failed connection, not only 
> connection-refused:
> {code:java}
> catch (ConnectException e) {
>     return true;
> }
> catch (IOException e) {
>     return false;
> }
> {code}
> 3) Timeout on connection checking should not be constand or hardcoced:
> {code:java}
> sock.connect(addr, 100);
> {code}
> 4) Decision to check connection should rely on configured exchange timeout, 
> no on the ping interval
> {code:java}
> // We got message from previous in less than double connection check interval.
> boolean ok = rcvdTime + U.millisToNanos(connCheckInterval) * 2 >= now;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to