[ https://issues.apache.org/jira/browse/IGNITE-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149688#comment-17149688 ]
Ignite TC Bot commented on IGNITE-12935: ---------------------------------------- {panel:title=Branch: [pull/7722/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/7722/head] Base: [master] : New Tests (11)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#00008b}PDS 2{color} [tests 3] * {color:#013220}IgnitePdsTestSuite2: IgniteWalRebalanceLoggingTest.testFullRebalanceLogMsgs - PASSED{color} * {color:#013220}IgnitePdsTestSuite2: IgniteWalRebalanceLoggingTest.testHistoricalRebalanceLogMsg - PASSED{color} * {color:#013220}IgnitePdsTestSuite2: IgniteWalRebalanceLoggingTest.testFullRebalanceWithShortCpHistoryLogMsgs - PASSED{color} {color:#00008b}Service Grid{color} [tests 4] * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=71f38fbe-fa60-4411-83d6-b5acdd2bc0e8, topVer=0, nodeId8=fdfe0196, msg=, type=NODE_JOINED, tstamp=1593445379902], val2=AffinityTopologyVersion [topVer=-2492070593086437179, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=71f38fbe-fa60-4411-83d6-b5acdd2bc0e8, topVer=0, nodeId8=fdfe0196, msg=, type=NODE_JOINED, tstamp=1593445379902], val2=AffinityTopologyVersion [topVer=-2492070593086437179, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=685e8c00371-15808eff-eb74-466a-8e55-0fb81d2b00fe, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=c6ae959b-6292-4f7e-94d4-5ee2a741c4aa, topVer=0, nodeId8=c6ae959b, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593445379902]], val2=AffinityTopologyVersion [topVer=-282040637918382668, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=685e8c00371-15808eff-eb74-466a-8e55-0fb81d2b00fe, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=c6ae959b-6292-4f7e-94d4-5ee2a741c4aa, topVer=0, nodeId8=c6ae959b, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593445379902]], val2=AffinityTopologyVersion [topVer=-282040637918382668, minorTopVer=0]]] - PASSED{color} {color:#00008b}Service Grid (legacy mode){color} [tests 4] * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=822c9c00371-a9abbef0-887c-4d96-978e-1e3c0384af3c, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=a6a60a67-e379-4bf6-98f1-23ae7274c8a2, topVer=0, nodeId8=a6a60a67, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593445458885]], val2=AffinityTopologyVersion [topVer=-6687727961648831972, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=822c9c00371-a9abbef0-887c-4d96-978e-1e3c0384af3c, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=a6a60a67-e379-4bf6-98f1-23ae7274c8a2, topVer=0, nodeId8=a6a60a67, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593445458885]], val2=AffinityTopologyVersion [topVer=-6687727961648831972, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=28008880-0458-4c7d-98c3-c62112aa1c38, topVer=0, nodeId8=71936a1f, msg=, type=NODE_JOINED, tstamp=1593445458885], val2=AffinityTopologyVersion [topVer=-3852995104049898338, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=28008880-0458-4c7d-98c3-c62112aa1c38, topVer=0, nodeId8=71936a1f, msg=, type=NODE_JOINED, tstamp=1593445458885], val2=AffinityTopologyVersion [topVer=-3852995104049898338, minorTopVer=0]]] - PASSED{color} {panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5425485&buildTypeId=IgniteTests24Java8_RunAll] > Disadvantages in log of historical rebalance > -------------------------------------------- > > Key: IGNITE-12935 > URL: https://issues.apache.org/jira/browse/IGNITE-12935 > Project: Ignite > Issue Type: Improvement > Reporter: Vladislav Pyatkov > Assignee: Vladislav Pyatkov > Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > # Mention in the log only partitions for which there are no nodes that suit > as historical supplier > For these partitions, print minimal counter (since which we should perform > historical rebalancing) with corresponding node and maximum reserved counter > (since which cluster can perform historical rebalancing) with corresponding > node. > This will let us know: > ## Whether history was reserved at all > ## How much reserved history we lack to perform a historical rebalancing > ## I see resulting output like this: > {noformat} > Historical rebalancing wasn't scheduled for some partitions: > History wasn't reserved for: [list of partitions and groups] > History was reserved, but minimum present counter is less than maximum > reserved: [[grp=GRP, part=ID, minCntr=cntr, minNodeId=ID, maxReserved=cntr, > maxReservedNodeId=ID], ...]{noformat} > ## We can also aggregate previous message by (minNodeId) to easily find the > exact node (or nodes) which were the reason of full rebalance. > # Log results of {{reserveHistoryForExchange()}}. They can be compactly > represented as mappings: {{(grpId -> checkpoint (id, timestamp))}}. For every > group, also log message about why the previous checkpoint wasn't successfully > reserved. > There can be three reasons: > ## Previous checkpoint simply isn't present in the history (the oldest is > reserved) > ## WAL reservation failure (call below returned false) > {code:java} > chpEntry = entry(cpTs); > boolean reserved = cctx.wal().reserve(chpEntry.checkpointMark());// If > checkpoint WAL history can't be reserved, stop searching. > if (!reserved) > break;{code} > ## Checkpoint was marked as inapplicable for historical rebalancing > {code:java} > for (Integer grpId : new HashSet<>(groupsAndPartitions.keySet())) > if (!isCheckpointApplicableForGroup(grpId, chpEntry)) > groupsAndPartitions.remove(grpId);{code} -- This message was sent by Atlassian Jira (v8.3.4#803005)