[
https://issues.apache.org/jira/browse/IGNITE-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178051#comment-15178051
]
Anton Vinogradov commented on IGNITE-2710:
------------------------------------------
Roman,
Looks good,
but:
1) Is there any reason to store isValid at writeExternal? I see that
cache.remove(ses) happens at ses.invalidate().
I removed isValid storage and see no test failures.
2) Seems that "GenuineSession" should be invalidated at ses.invalidate, not at
next getSession() request. (super.invalidate() should be invoked)
3) WebSession ses at RequestWrapper should be marked as volatile
4) getSession at RequestWrapper should return invalid session instead of null
> Session not unbind from current request after invoking
> request.getSession().invalidate()
> ----------------------------------------------------------------------------------------
>
> Key: IGNITE-2710
> URL: https://issues.apache.org/jira/browse/IGNITE-2710
> Project: Ignite
> Issue Type: Bug
> Components: cache
> Affects Versions: 1.5.0.final
> Environment: java8, tomcat8
> Reporter: YuxuanWang
> Assignee: Roman Shtykh
> Labels: community, session, user
> Fix For: 1.6
>
>
> System.out.println(request.getSession().getId());
> request.getSession().invalidate();
> System.out.println(request.getSession().getId());
> getSession() although return the same session after the invalidation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
