[ 
https://issues.apache.org/jira/browse/IGNITE-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179927#comment-15179927
 ] 

Oddo commented on IGNITE-2693:
------------------------------

Vladimir,

I agree with you. I think there are two ways to solve this: one is to throw an 
exception if withKeepBinary() is invoked on a cache that does not have a binary 
marshaller. The other is just to silently return the same cache. I think the 
former solution is probably better since it alerts the user to the fact that 
they are trying to do something "illegal".

I think the tests should consist of exercising these two behavior paths and 
that should be that. Let me know what you think.

> withKeepBinary and non-binary marshallers
> -----------------------------------------
>
>                 Key: IGNITE-2693
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2693
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>            Reporter: Sergey Kozlov
>            Assignee: Oddo
>              Labels: newbie
>             Fix For: 1.6
>
>
> Currently the user is able to set {{.withKeepBinary()}} for any used 
> marshaller. But it obviously causes ClassCastException for non-binary 
> marshallers and should be available only for binary marshaller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to