[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172093#comment-17172093
]
Aleksey Kurinov commented on IGNITE-13040:
------------------------------------------
[~vladsz83] I've updated source code according you your recommendations.
{color:#24292e}TcpDiscoveryConnectionCheckMessage
{color:#003000}m{color}{color}essage stub is used according to your comment
{color:#24292e}// Replace logic routine message with a stub to update
last-sent-time to avoid segmentation on{color}
{color:#24292e} // connRecoveryTimeout.{color}
{color:#24292e}please review PR changes to check if I updated it
correctly{color}
[~slava.koptilin] , [~vladsz83] test still fail in TeamCity and i'm not sure why
here is the link to report in teamcity Bot:
[https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/7977/head&action=Latest]
to double check I submitted another Pull Request with a minor change against
master branch. I just added a comment line. TemCity test also failed for this
fake PR:
[https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/8121/head&action=Latest]
Please clarify how to get TeamCity test passed ?
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
> ------------------------------------------------------------
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
> Reporter: Vladimir Steshin
> Assignee: Aleksey Kurinov
> Priority: Trivial
> Labels: newbie
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
