[
https://issues.apache.org/jira/browse/IGNITE-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186809#comment-15186809
]
Denis Magda commented on IGNITE-2394:
-------------------------------------
[~alpert],
Sure you can assign this ticket on yourself and contribute the fix.
Answering on your questons.
> IgniteCacheProxy.loadCache that it checks cache type and if cache is local it
> calls cache().localLoadCache.
> So when you call either client or server cache is only loaded locally. Is
> that the correct way to imlement?
Yes, this looks good to me.
In addition you have to modify {{globalLoadCacheAsync}} implementation
according to the description because the current fix doesn't take into account
all the cases.
Finally, make sure to add missing tests that will check that you fix works fine
and validate the fix following the pull-requests based contribution [1]
[1]
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request
> Cache loading from storage is called on client nodes
> ----------------------------------------------------
>
> Key: IGNITE-2394
> URL: https://issues.apache.org/jira/browse/IGNITE-2394
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 1.5.0.final
> Reporter: Denis Magda
> Priority: Critical
> Labels: newbie
> Fix For: 1.6
>
> Attachments: LocalLoadTest.java, master_baa1312_IGNITE-2394.patch
>
>
> If to call cache.loadCache(...) then the loading from a storage will happen
> on all the nodes including client nodes.
> However, client nodes must be filtered out.
> If to be more precise at least this place of the code has to be modified
> {noformat}
> IgniteInternalFuture<?> globalLoadCacheAsync(@Nullable
> IgniteBiPredicate<K, V> p, @Nullable Object... args)
> throws IgniteCheckedException {
> ClusterGroup nodes =
> ctx.kernalContext().grid().cluster().forCacheNodes(ctx.name());
> {noformat}
> where forDataNodes() has to be used instead of forCacheNodes().
> Also additional tests have to be added.
> Discussion on the user list:
> http://apache-ignite-users.70518.x6.nabble.com/Loadcache-behavior-tp2571.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
