[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177134#comment-17177134
]
Vladimir Steshin edited comment on IGNITE-13040 at 8/13/20, 5:49 PM:
---------------------------------------------------------------------
[~Kurinov], you can check certain tests locally. Buy you should launch them on
Linux/Mac. As an example
{code:java}
TcpClientDiscoverySpiSelfTest.testReconnectSegmentedAfterJoinTimeoutNetworkError()
{code} fails in this PR and has to be fixed after the code change.
Also, you can try to update master, merge it into the ticket's branch and
re-run the tests. Then, keep re-running blockers. It should help. It could
appear you have to re-run blockers approximately up to 3-5 times. If the keep
failing, try checking the failed tests locally. They might become broken due to
the PR.
Btw., you can find me in Slack: Vladimir St.
was (Author: vladsz83):
[~Kurinov], you can check certain tests locally. Buy you should launch them on
Linux/Mac. As an example
{code:java}
TcpClientDiscoverySpiSelfTest.testReconnectSegmentedAfterJoinTimeoutNetworkError()
{code} fails in this PR and has to be fixed after the code change.
Also, you can try to update master, merge it into the ticket's branch and
re-run the tests. Then, keep re-running blockers. It should help. It could
appear you have to re-run blockers approximately up to 3-5 times. If the keep
failing, try checking the failed tests locally. They might become broken due to
the PR.
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
> ------------------------------------------------------------
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
> Reporter: Vladimir Steshin
> Assignee: Aleksey Kurinov
> Priority: Trivial
> Labels: newbie
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
