[ https://issues.apache.org/jira/browse/IGNITE-13296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190620#comment-17190620 ]
Pavel Tupitsyn commented on IGNITE-13296: ----------------------------------------- [~GuruStron] I've reviewed the PR - looks good to me. Please see a couple minor comments. > .NET: TransactionImpl finalizer can crash the process > ----------------------------------------------------- > > Key: IGNITE-13296 > URL: https://issues.apache.org/jira/browse/IGNITE-13296 > Project: Ignite > Issue Type: Bug > Components: platforms > Reporter: Pavel Tupitsyn > Assignee: Sergey Stronchinskiy > Priority: Major > Labels: .NET > Fix For: 2.10 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > ~TransactionImpl potentially throws an exception (e.g. when grid is stopped), > causing the entire process to abort. > GetLocalActiveTransactions is especially problematic - the method is > informational, yet will result in all the returned transactions to be > finalized later. > * Finalizers should not throw exceptions > * Stopped grid is a valid use case > * GetLocalActiveTransactions should be fixed to return "read-only" > transactions that won't be finalized > Review all filalizers and make sure they are safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)