[ 
https://issues.apache.org/jira/browse/IGNITE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220565#comment-17220565
 ] 

Alexey Scherbakov commented on IGNITE-13393:
--------------------------------------------

[~alapin]
 # Current _ASYNC tracing semantics seems questionable to me. What's the point 
in tracing future creation? IMO sync and async ops should be traced similarly. 
I would remove _ASYNC scopes at all, instead use async=true tag to 
differentiate between sync and async contexts.
 # removeAll is a distributed operation. It's entry point in 
GridDistributedCacheAdapter#removeAll. Looks like it's not traced properly.
 # What about other "update" operation, like invokes and filtered updates ? I 
think the tracing implementaion should be unified with puts, using methods 
org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache#update0
 and 
org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache#updateAll0
 as entry points.
 # In addition to removeAll a cache can be cleared using clear(), which uses 
jobs for local clearing. Should it be traced as well ?

> Tracing: Atomic cache read/write flow.
> --------------------------------------
>
>                 Key: IGNITE-13393
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13393
>             Project: Ignite
>          Issue Type: New Feature
>            Reporter: Alexander Lapin
>            Assignee: Alexander Lapin
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Implement tracing for atomic cache operations:
>  * put
>  * putAll
>  * putAsync
>  * putAllAsync
>  * remove
>  * removeAll
>  * removeAsync
>  * removeAllAsync
>  * get
>  * getAll
>  * getAsync
>  * getAllAsync
> Also add ability to include root cache read/write operations to tx tracing 
> flow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to