[
https://issues.apache.org/jira/browse/IGNITE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238438#comment-17238438
]
Vyacheslav Koptilin commented on IGNITE-13450:
----------------------------------------------
Hello [~SomeFire], [~nizhikov],
Unfortunately, I was late to review this change but, anyway, please take into
account the following:
- first of all, Javadoc of {{EventType.EVT_SQL_QUERY_EXECUTION}} and
{{SqlQueryExecutionEvent}} looks like copy&paste and does not provide any
specific information about this event. At least, it would be useful to clearly
state the phase of query execution that triggers this event and etc. The
Javadoc is the face of the product and it must be good enough, especially if we
are talking about public API.
- {{SqlQueryExecutionEvent#args}} may contain sensitive information and should
be masked by *** when
{{IgniteSystemProperties#IGNITE_TO_STRING_INCLUDE_SENSITIVE}} is {{false}}.
> Add event fired before query execution
> --------------------------------------
>
> Key: IGNITE-13450
> URL: https://issues.apache.org/jira/browse/IGNITE-13450
> Project: Ignite
> Issue Type: Task
> Reporter: Ryabov Dmitrii
> Assignee: Ryabov Dmitrii
> Priority: Minor
> Labels: event
> Fix For: 2.10, 2.9.1
>
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> Create {{SQLQueryExecutionEvent}}, which will be fired before SQL query
> execution.
> Required fields are:
> - text of a query (with hidden arguments);
> - arguments of query;
> - query type;
> - node id.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
