[ 
https://issues.apache.org/jira/browse/IGNITE-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196938#comment-15196938
 ] 

Roman Shtykh commented on IGNITE-813:
-------------------------------------

Saikat,

I have several comments.

First of all, please refactor the code, as Anton mentioned.
To give you some idea what is missing and how it should look after you read 
"Coding Guidelines", please see 
https://github.com/shroman/ignite/commit/6e92f767ea65392ae1bf1e108492e6b9bdf5878b

Also,
1. Please use IgniteDataStreamer. You won't need IgniteQueue in this case.
2. What is the topology in README? Would it be correct to mention 
{{input.addSink(igniteSinkObject)}}?

Also, Flink integration can be done in various ways -- this one is an 
integration via streaming connectors. To be precise, I will change the title of 
this ticket ;)

> Apache Flink Integration
> ------------------------
>
>                 Key: IGNITE-813
>                 URL: https://issues.apache.org/jira/browse/IGNITE-813
>             Project: Ignite
>          Issue Type: New Feature
>            Reporter: Suminda Dharmasena
>            Assignee: Saikat Maitra
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to