[ https://issues.apache.org/jira/browse/IGNITE-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261316#comment-17261316 ]
Stanislav Lukyanov commented on IGNITE-13364: --------------------------------------------- The patch LGTM! I've started a devlist discussion on this since this has a compatibility impact and probably should be discussed before merging. https://lists.apache.org/thread.html/r22ca5271f590816517d4afbc7df633c1c3f39d01657241902e710595%40%3Cdev.ignite.apache.org%3E > Improve index inline defaults > ------------------------------ > > Key: IGNITE-13364 > URL: https://issues.apache.org/jira/browse/IGNITE-13364 > Project: Ignite > Issue Type: Improvement > Components: sql > Reporter: Evgeniy Rudenko > Assignee: Evgeniy Rudenko > Priority: Major > Fix For: 2.10 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We need to improve how inline size is calculated by default for > variable-length types. > Currently if a varlength type is encountered inline size just defaults to 10, > which is almost always not enough. > A more sensible behavior would be the following: > 1. Add a fixed default to the inline size calculation for every > variable-length type. For example, if the default inlined size for a string > is 10 then an index like (INT, VARCHAR, VARCHAR, INT) should have inline size > default as 5 + 10 + 10 + 5 = 30 (5 for each int, 10 for each string). > 2. Add special support for VARCHAR_FIXED - if a VARCHAR has known length then > that length is used for inline size calculation -- This message was sent by Atlassian Jira (v8.3.4#803005)