[
https://issues.apache.org/jira/browse/IGNITE-14000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269277#comment-17269277
]
Vyacheslav Koptilin commented on IGNITE-14000:
----------------------------------------------
Hello [~kgusakov],
I left a few comments on your PR. Please take a look.
> Ignite 3.0: Fix codestyle for cli and cli-common packages
> ---------------------------------------------------------
>
> Key: IGNITE-14000
> URL: https://issues.apache.org/jira/browse/IGNITE-14000
> Project: Ignite
> Issue Type: Bug
> Reporter: Alexey Goncharuk
> Assignee: Kirill Gusakov
> Priority: Major
> Labels: ignite-3, ignite-3-cli-tool
> Fix For: 3.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, the listed modules do not conform Ignite Coding Giudelines [1]:
> * classes are poorly formatted (e.g. braces for one-line if/for statements,
> invalid spacing for fields and statements blocks)
> * classes lack proper javadocs
> * packages missing package-info.java
> * code contains TODOs without tickets (tickets either should be created or
> TODOs removed/fixed)
> * code contains commented code blocks
> * Some error messages should be fixed ("Fail to..." -> "Failed to...",
> remove usages of "Please")
> [1] https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
> [2] https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
