[
https://issues.apache.org/jira/browse/IGNITE-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294803#comment-17294803
]
Maksim Timonin commented on IGNITE-13056:
-----------------------------------------
Hi [~korlov] , [~amashenkov] !
Thanks for all comments. I've fixed most of them, the biggest changes are:
# Rework of hierarchies: IndexRow, IndexKey;
# Hide packages from public to internal;
# Restore backward compatibility for POJO type;
# Replace Schema with RowHandler;
# Introduce interfaces for date/time keys and delegates implementations to H2
(as it contains a lot of custom H2 logic, and license of h2 does not allow use
this code, only in binary form).
For most of other comments I provide fixes, comment them and resolve issues.
Some of issues are not resolved to just clearify that my fix is correct.
The only things to finalize:
# Cursor implementations can't be implemented other way as H2 ("select
max(col) from table" query) depends on the logic that it invokes get() before
next(). Currently I see a single way - put a comment there and fix with Calcite
integration.
# MVCC tests, including C++ mvcc test, can I just remove all of them?
# If design is OK, then I will run performance tests.
Could you please review my PR again?
> SchemaManager refactoring
> -------------------------
>
> Key: IGNITE-13056
> URL: https://issues.apache.org/jira/browse/IGNITE-13056
> Project: Ignite
> Issue Type: New Feature
> Components: sql
> Affects Versions: 2.8
> Reporter: Nikolay Izhikov
> Assignee: Maksim Timonin
> Priority: Major
> Labels: IEP-49, calcite
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Since Ignite wants to leverage from several SQL engines we need to make work
> with index independent from the used SQL engine.
> We also should consider moving all machinery related to an index to the core
> module to make it available from any module that wants to use it.
> Requirements so far:
> * Ability to track indexes in several engines
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
