[ 
https://issues.apache.org/jira/browse/IGNITE-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302351#comment-17302351
 ] 

Sergey Chugunov commented on IGNITE-14224:
------------------------------------------

[~zstan],

Patch looks good to me as well, I merged it to master branch in commit 
*8e154f0d7eee5825c82e6158f3dac725d7bfe847*.

Thank you for contribution!

> Extend logging of client failure handling.
> ------------------------------------------
>
>                 Key: IGNITE-14224
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14224
>             Project: Ignite
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 2.9.1
>            Reporter: Stanilovsky Evgeny
>            Assignee: Stanilovsky Evgeny
>            Priority: Major
>             Fix For: 2.11
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> # "Finished serving remote node connection " but this message doesn't contain 
> node id, it should be added (check 
> org.apache.ignite.spi.discovery.tcp.ServerImpl.SocketReader#body).
>  # When client worker is removed from clientMsgWorkers, 
> org.apache.ignite.internal.util.IgniteUtils#closeQuiet(java.lang.AutoCloseable)
>  is used to close the socket, we don't see any exception if it has happened, 
> closeQuiet should be replaced with 
> org.apache.ignite.internal.util.IgniteUtils#close(java.lang.AutoCloseable, 
> org.apache.ignite.IgniteLogger) which works in the same way but prints 
> exception.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to