[ 
https://issues.apache.org/jira/browse/IGNITE-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302658#comment-17302658
 ] 

Konstantin Orlov commented on IGNITE-14274:
-------------------------------------------

[~tledkov-gridgain], the patch looks good to me

> Calcite integration: refactoring aggregates converter rules: single and 
> map/reduce
> ----------------------------------------------------------------------------------
>
>                 Key: IGNITE-14274
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14274
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>            Reporter: Taras Ledkov
>            Assignee: Taras Ledkov
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> We have to use converter rules to create single & map+reduce aggregates 
> instead of creates map/reduce aggregates on handle traits at the single 
> aggregates.
> Now:
> SortAggregateConverterRule
> HashAggregateConverterRule
> Must be:
> SortSingleAggregateConverterRule
> SortMapReduceAggregateConverterRule
> HashSingleAggregateConverterRule
> HashMapReduceAggregateConverterRule



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to