[ 
https://issues.apache.org/jira/browse/IGNITE-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Petrov updated IGNITE-14428:
------------------------------------
    Description: 
It's needed to refactor metric names to obey the global rule - all of them must 
start with name of the registry they belongs to. And add corresponding 
assertion.

The purpose of this change is to make all metrics that belongs to one 
MetricRegistry have the name that obeys mentioned above rule regardless how 
they were registered. It helps to use a consistent approach to work with all 
metrics.

The following metric names will be changed to obey this rule:

JoinedNodes -> io.discovery.JoinedNodes 
 LeftNodes -> io.discovery.LeftNodes
 FailedNodes -> io.discovery.FailedNodes 
 PendingMessagesRegistered -> io.discovery.PendingMessagesRegistered
 CommunicationErrors -> io.discovery.CommunicationErrors
 CurrentTopologyVersion -> io.discovery.CurrentTopologyVersion

  was:
It's needed to refactor metric names to obey the global rule - all of them must 
start with name of the registry they belongs to. And add corresponding 
assertion.

The purpose of this change is to make all metrics that belongs to one 
MetricRegistry have the name that obeys mentioned above rule regardless how 
they were registered. It helps to use a consistent approach to work with all 
metrics.

The following metric names will be changed to obey this rule:

JoinedNodes -> io.discovery.JoinedNodes 
LeftNodes -> io.discovery.LeftNodes
FailedNodes -> io.discovery.FailedNodes 
PendingMessagesRegistered -> io.discovery.JPendingMessagesRegistered
CommunicationErrors -> io.discovery.CommunicationErrors
CurrentTopologyVersion -> io.discovery.CurrentTopologyVersion


> Formalize the names of the metrics included in the metric registry. 
> --------------------------------------------------------------------
>
>                 Key: IGNITE-14428
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14428
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Mikhail Petrov
>            Assignee: Mikhail Petrov
>            Priority: Major
>              Labels: IEP-35
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> It's needed to refactor metric names to obey the global rule - all of them 
> must start with name of the registry they belongs to. And add corresponding 
> assertion.
> The purpose of this change is to make all metrics that belongs to one 
> MetricRegistry have the name that obeys mentioned above rule regardless how 
> they were registered. It helps to use a consistent approach to work with all 
> metrics.
> The following metric names will be changed to obey this rule:
> JoinedNodes -> io.discovery.JoinedNodes 
>  LeftNodes -> io.discovery.LeftNodes
>  FailedNodes -> io.discovery.FailedNodes 
>  PendingMessagesRegistered -> io.discovery.PendingMessagesRegistered
>  CommunicationErrors -> io.discovery.CommunicationErrors
>  CurrentTopologyVersion -> io.discovery.CurrentTopologyVersion



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to