[ 
https://issues.apache.org/jira/browse/IGNITE-14511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319091#comment-17319091
 ] 

Ivan Daschinsky commented on IGNITE-14511:
------------------------------------------

*BinaryObject before*
{code}

--------------------------------------------------------------------------------------------
 benchmark 'binary_object_get': 6 tests 
--------------------------------------------------------------------------------------------
Name (time in us)                                    Min                   Max  
                Mean              StdDev                Median                 
IQR            Outliers         OPS            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark_sync_binary_get[simple-1024]          511.5891 (1.0)        608.8095 
(1.06)       546.5089 (1.00)      33.2744 (2.48)       535.8704 (1.0)       
41.5688 (3.39)          3;0  1,829.7964 (1.00)         10         100
benchmark_sync_binary_get[simple-4096]          527.0679 (1.03)       573.9422 
(1.0)        546.4653 (1.0)       13.4347 (1.0)        546.2277 (1.02)      
12.2446 (1.0)           3;1  1,829.9425 (1.0)          10         100
benchmark_sync_binary_get[simple-10240]         550.1763 (1.08)     1,864.2935 
(3.25)       725.8725 (1.33)     401.8950 (29.91)      593.1420 (1.11)      
84.5819 (6.91)          1;1  1,377.6523 (0.75)         10         100
benchmark_sync_binary_get[simple-102400]      1,015.8495 (1.99)     1,163.2109 
(2.03)     1,052.0917 (1.93)      42.5464 (3.17)     1,042.2522 (1.94)      
20.8015 (1.70)          1;1    950.4875 (0.52)         10         100
benchmark_sync_binary_get[simple-512000]      3,301.8673 (6.45)     3,515.9787 
(6.13)     3,433.9338 (6.28)      74.9665 (5.58)     3,441.8588 (6.42)     
117.2729 (9.58)          4;0    291.2112 (0.16)         10         100
benchmark_sync_binary_get[simple-1048576]     5,951.7170 (11.63)    6,675.8632 
(11.63)    6,331.3688 (11.59)    184.1940 (13.71)    6,338.2842 (11.83)    
140.9198 (11.51)         2;2    157.9437 (0.09)         10         100
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

--------------------------------------------------------------------------------------------
 benchmark 'binary_object_put': 6 tests 
--------------------------------------------------------------------------------------------
Name (time in us)                                    Min                   Max  
                Mean              StdDev                Median                 
IQR            Outliers         OPS            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark_sync_binary_put[simple-1024]          412.7491 (1.0)        476.5644 
(1.0)        442.1452 (1.0)       20.3006 (1.0)        436.8521 (1.0)       
29.7126 (1.11)          3;0  2,261.7003 (1.0)          10         100
benchmark_sync_binary_put[simple-4096]          441.0307 (1.07)       587.2322 
(1.23)       479.9080 (1.09)      40.8717 (2.01)       468.4593 (1.07)      
26.7977 (1.0)           1;1  2,083.7326 (0.92)         10         100
benchmark_sync_binary_put[simple-10240]         483.9162 (1.17)       701.0896 
(1.47)       551.1292 (1.25)      75.3323 (3.71)       522.2965 (1.20)      
93.8169 (3.50)          2;0  1,814.4567 (0.80)         10         100
benchmark_sync_binary_put[simple-102400]      1,040.0957 (2.52)     1,227.4130 
(2.58)     1,105.9717 (2.50)      59.5590 (2.93)     1,096.3965 (2.51)      
58.0674 (2.17)          3;1    904.1823 (0.40)         10         100
benchmark_sync_binary_put[simple-512000]      3,017.7975 (7.31)     3,477.9179 
(7.30)     3,240.2499 (7.33)     147.8984 (7.29)     3,187.6080 (7.30)     
235.8838 (8.80)          3;0    308.6182 (0.14)         10         100
benchmark_sync_binary_put[simple-1048576]     5,914.6568 (14.33)    7,389.2629 
(15.51)    6,175.4214 (13.97)    447.3971 (22.04)    6,005.6895 (13.75)    
240.1667 (8.96)          1;1    161.9323 (0.07)         10         100
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
{code}

*BinaryObject after*
{code}

--------------------------------------------------------------------------------------------
 benchmark 'binary_object_get': 6 tests 
--------------------------------------------------------------------------------------------
Name (time in us)                                    Min                   Max  
                Mean              StdDev                Median                 
IQR            Outliers         OPS            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark_sync_binary_get[simple-1024]          433.8004 (1.0)        545.9889 
(1.09)       470.7149 (1.0)       34.5206 (2.95)       462.7400 (1.0)       
37.5861 (2.60)          3;1  2,124.4281 (1.0)          10         100
benchmark_sync_binary_get[simple-4096]          464.5142 (1.07)       503.1639 
(1.0)        486.0367 (1.03)      11.7073 (1.0)        488.0442 (1.05)      
14.4475 (1.0)           4;0  2,057.4579 (0.97)         10         100
benchmark_sync_binary_get[simple-10240]         500.7827 (1.15)       557.9731 
(1.11)       525.1197 (1.12)      16.6869 (1.43)       519.2064 (1.12)      
22.8062 (1.58)          3;0  1,904.3277 (0.90)         10         100
benchmark_sync_binary_get[simple-102400]        904.3337 (2.08)     1,002.9530 
(1.99)       970.9484 (2.06)      27.8128 (2.38)       982.5036 (2.12)      
25.9701 (1.80)          2;1  1,029.9208 (0.48)         10         100
benchmark_sync_binary_get[simple-512000]      2,650.7654 (6.11)     3,405.1033 
(6.77)     2,888.2118 (6.14)     270.1149 (23.07)    2,804.8139 (6.06)     
131.4979 (9.10)          2;2    346.2350 (0.16)         10         100
benchmark_sync_binary_get[simple-1048576]     6,227.5759 (14.36)    6,829.2870 
(13.57)    6,498.1416 (13.80)    182.8220 (15.62)    6,480.1388 (14.00)    
188.0765 (13.02)         3;0    153.8902 (0.07)         10         100
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

--------------------------------------------------------------------------------------------
 benchmark 'binary_object_put': 6 tests 
--------------------------------------------------------------------------------------------
Name (time in us)                                    Min                   Max  
                Mean              StdDev                Median                 
IQR            Outliers         OPS            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark_sync_binary_put[simple-1024]          369.0318 (1.0)        393.3923 
(1.0)        379.1346 (1.0)        9.4729 (1.0)        376.4724 (1.0)       
20.1658 (1.32)          4;0  2,637.5855 (1.0)          10         100
benchmark_sync_binary_put[simple-4096]          382.5254 (1.04)       413.0906 
(1.05)       396.7855 (1.05)       9.9890 (1.05)       398.2678 (1.06)      
15.2327 (1.0)           3;0  2,520.2532 (0.96)         10         100
benchmark_sync_binary_put[simple-10240]         432.7266 (1.17)       486.2474 
(1.24)       459.1455 (1.21)      15.1982 (1.60)       458.9262 (1.22)      
19.8728 (1.30)          3;0  2,177.9589 (0.83)         10         100
benchmark_sync_binary_put[simple-102400]        913.0787 (2.47)       972.2936 
(2.47)       936.4762 (2.47)      20.0059 (2.11)       935.6075 (2.49)      
33.6852 (2.21)          3;0  1,067.8328 (0.40)         10         100
benchmark_sync_binary_put[simple-512000]      3,018.9246 (8.18)     3,399.8477 
(8.64)     3,165.2541 (8.35)     129.1270 (13.63)    3,154.6684 (8.38)     
230.0669 (15.10)         3;0    315.9304 (0.12)         10         100
benchmark_sync_binary_put[simple-1048576]     5,962.9520 (16.16)    6,355.5031 
(16.16)    6,184.5988 (16.31)    154.0188 (16.26)    6,226.3332 (16.54)    
305.3462 (20.05)         4;0    161.6920 (0.06)         10         100
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

{code}

> Putting bytes to cache converted to string by default.
> ------------------------------------------------------
>
>                 Key: IGNITE-14511
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14511
>             Project: Ignite
>          Issue Type: Bug
>          Components: python, thin client
>    Affects Versions: python-0.3.4
>            Reporter: Ivan Daschinsky
>            Assignee: Ivan Daschinsky
>            Priority: Major
>             Fix For: python-0.4.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, when you put {{b'\x01\x02}} to cache without a type hint, you
> will get string {{'\x01\x02'}}. It is very confusing. If you put {{bytes}} 
> with 
> {{value_hint=ByteArrayObject}} you will get {{bytearray}}. As for me, it is 
> quite
> strange to return mutable {{bytearray}} instead of {{bytes}}
> I suggest following:
> 1. By default treat {{bytes}} as {{ByteArrayObject}}
> 2. Method {{to_python}} of {{ByteArrayObject}} to {{bytes}}, not to 
> {{bytearray}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to