[
https://issues.apache.org/jira/browse/IGNITE-14601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326528#comment-17326528
]
Anton Vinogradov commented on IGNITE-14601:
-------------------------------------------
This task happened during the Snapshot test simplification.
The goal was to just change loader params and load another data again, without
node freeing and another IgniteAware instance creation.
Before:
{noformat}
loader = IgniteApplicationService(
self.test_context,
client_config,
java_class_name="org.apache.ignite.internal.ducktest.tests.snapshot_test.DataLoaderApplication",
params={
"start": 500_000,
"cacheName": self.CACHE_NAME,
"interval": 100_000,
"valueSizeKb": 1
}
)
loader.start(clean=False)
loader.wait()
// loader stop was missed here %(
{noformat}
After:
{noformat}
loader.params = {"start": 500_000, "cacheName": self.CACHE_NAME, "interval":
100_000, "valueSizeKb": 1}
loader.run()
{noformat}
But found we have service's params duplication inside specs, so params change
has no effect.
So, I got rid of the service's params duplication inside the spec to make this
possible.
As a bonus, I simplified specs and get rid of spaghetti params :)
Fix confirmed by successful Jenkins run.
[~ivandasch], [~northdragon], please review the changes.
> Specs should use service's params instead of copying.
> -----------------------------------------------------
>
> Key: IGNITE-14601
> URL: https://issues.apache.org/jira/browse/IGNITE-14601
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Anton Vinogradov
> Assignee: Anton Vinogradov
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently a lot of params copied to spec.
> Need just to use {{self.service.xxx}} instead
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
