[
https://issues.apache.org/jira/browse/IGNITE-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337428#comment-17337428
]
Taras Ledkov commented on IGNITE-14545:
---------------------------------------
[~alex_pl], the patch is OK with me.
Please fix minors:
1. {{test_unicode.test_ignored}} contains reference to this ticket too. Please
fix the test.
2. I modified any scripts (includes {{test_aggr_string.test}}) before team
generates a style for {{_ignored}} test.
We didn't have time to create small document.
But the style rule is short and easy:
It seems to be more convenient when a passed test script is *a subset *of the
full script that marked as {{_ignored}}.
In this case a simple diff between {{<script>.test}} and
{{<script>.test_ignore}} shows fails.
Could you please change the {{test_aggr_string.test}} according above. Sorry
for my initial change that breaks this style.
> Calcite engine. Unicode literal not supported
> ---------------------------------------------
>
> Key: IGNITE-14545
> URL: https://issues.apache.org/jira/browse/IGNITE-14545
> Project: Ignite
> Issue Type: Bug
> Reporter: Taras Ledkov
> Assignee: Aleksey Plekhanov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Unicode literal not supported.
> e.g. {{SELECT <any_string_with_unicode_symbols>}}
> Tests:
> {{aggregate/aggregates/test_aggr_string.test}}
> {{types/string/test_unicode.test_ignored}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
