[
https://issues.apache.org/jira/browse/IGNITE-14828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359106#comment-17359106
]
Mirza Aliev commented on IGNITE-14828:
--------------------------------------
[~sk0x50] Hello! Could you please review the changes?
> No fallback to full rebalance after exception on historical
> -----------------------------------------------------------
>
> Key: IGNITE-14828
> URL: https://issues.apache.org/jira/browse/IGNITE-14828
> Project: Ignite
> Issue Type: Bug
> Reporter: Mirza Aliev
> Assignee: Mirza Aliev
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have noticed that in some cases when we handle demand message in
> {{GridDhtPartitionSupplier.java}} it is possible for some reasons that
> {code:java}
> iter = grp.offheap().rebalanceIterator(demandMsg.partitions(),
> demandMsg.topologyVersion());
> {code}
> throw an exception. In that case, rebalance should switch to full, but the
> code has a bug and {{remainingParts}} has been filed after rebalance iterator
> has been created
> {code:java}
> for (int i = 0; i < histMap.size(); i++) {
> int p = histMap.partitionAt(i);
> remainingParts.add(p);
> }
> {code}
> That means that we lost partitions that meant to be rebalanced by historical
> rebalance.
> The solution is to create an iterator after {{remainingParts}} filling.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
