Stanislav Lukyanov created IGNITE-15688:
-------------------------------------------

             Summary: IgniteClient.close shouldn't throw Exception
                 Key: IGNITE-15688
                 URL: https://issues.apache.org/jira/browse/IGNITE-15688
             Project: Ignite
          Issue Type: Bug
          Components: thin client
            Reporter: Stanislav Lukyanov


IgniteClient interfaecs currently doesn't override close() from AutoClosable. 
Because of that it inherits `close() throws Exception` forcing all users to 
catch Exception when using IgniteClient.

 

In fact, this shouldn't be required. `TcpIgniteClient implements IgniteClient` 
currently throws Exception but it doesn't need to - its code doesn't throw any 
checked exceptions.

 

Proposal:
 # Add `@Overrides public void close()` with no `throws` to IgniteClient.
 # Remove `throws Exception` from `TcpIgniteClient::close`

Note: this change is fully backwards-compatible. It is legal to narrow the 
scope of `throws` in a new version of a method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to