[
https://issues.apache.org/jira/browse/IGNITE-15688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424955#comment-17424955
]
Ignite TC Bot commented on IGNITE-15688:
----------------------------------------
{panel:title=Branch: [pull/9475/head] Base: [master] : Possible Blockers
(5)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}SPI{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=6212651]]
* IgniteSpiTestSuite:
TcpDiscoveryPendingMessageDeliveryTest.testDeliveryAllFailedMessagesInCorrectOrder
- Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Control Utility (Zookeeper){color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=6212715]]
{color:#d04437}Cache 8{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=6212684]]
* IgniteCacheTestSuite8:
GridCacheConcurrentEvictionConsistencySelfTest.testPolicyConsistencySortedLocalFewKeys
- Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Platform C++ CMake (Win x64 / Release){color} [[tests 0 TIMEOUT
, Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=6212716]]
{color:#d04437}Platform C++ (Win x64 / Release){color} [[tests 0 TIMEOUT , Exit
Code |https://ci.ignite.apache.org/viewLog.html?buildId=6212660]]
{panel}
{panel:title=Branch: [pull/9475/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6212723&buildTypeId=IgniteTests24Java8_RunAll]
> IgniteClient.close shouldn't throw Exception
> --------------------------------------------
>
> Key: IGNITE-15688
> URL: https://issues.apache.org/jira/browse/IGNITE-15688
> Project: Ignite
> Issue Type: Bug
> Components: thin client
> Reporter: Stanislav Lukyanov
> Assignee: Stanislav Lukyanov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> IgniteClient interface currently doesn't override close() from AutoClosable.
> Because of that, it inherits `close() throws Exception` forcing all users to
> catch Exception when using IgniteClient.
>
> In fact, this shouldn't be required. `TcpIgniteClient implements
> IgniteClient` currently throws Exception but it doesn't need to - its code
> doesn't throw any checked exceptions.
>
> Proposal:
> # Add `@Overrides public void close()` with no `throws` to IgniteClient.
> # Remove `throws Exception` from `TcpIgniteClient::close`
> Note: this change is fully backwards-compatible. It is legal to narrow the
> scope of `throws` in a new version of a method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
